Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Storage Access API integration to match latest spec #133

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Update Storage Access API integration to match latest spec #133

merged 3 commits into from
Feb 3, 2023

Conversation

johannhof
Copy link
Member

@johannhof johannhof commented Jan 31, 2023 •
edited by pr-preview bot
Loading

@johannhof
Copy link
Member Author

@jyasskin would you mind giving this a quick review? Don't think I can add you as a reviewer because GitHub is weird...

@johannhof johannhof requested review from jyasskin and removed request for krgovind February 2, 2023 21:21
jyasskin
jyasskin approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once you've aborted steps in the right place.

spec.bs Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@johannhof johannhof merged commit 9b349f0 into WICG:main Feb 3, 2023
@johannhof johannhof deleted the update-saa branch February 3, 2023 10:14
github-actions bot added a commit that referenced this pull request Feb 3, 2023
@johannhof @github-actions
Update Storage Access API integration to match latest spec (#133)
ffb653e 
SHA: 9b349f0
Reason: push, by johannhof

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to johannhof/first-party-sets that referenced this pull request Feb 6, 2023
@johannhof @github-actions
Update Storage Access API integration to match latest spec (WICG#133)
192cbfb 
SHA: 9b349f0
Reason: push, by johannhof

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyasskin jyasskin jyasskin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannhof @jyasskin